fix(editor): match task list item spacing with bullet and ordered lists#62
Open
sfarestam wants to merge 1 commit intodebuglebowski:mainfrom
Open
fix(editor): match task list item spacing with bullet and ordered lists#62sfarestam wants to merge 1 commit intodebuglebowski:mainfrom
sfarestam wants to merge 1 commit intodebuglebowski:mainfrom
Conversation
Task list items had margin-top/bottom: 0 and a custom line-height: 1.25, while regular list items used 0.125em margins and inherited line-height. This caused visible spacing differences between list types. Align both TipTap and Milkdown task list items to use the same 0.125em margins and inherited line-height as other list items. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
margin: 0andline-height: 1.25, while bullet/ordered list items usedmargin: 0.125emand inherited line-height0.125emmargins and inherited line-heightTest plan
🤖 Generated with Claude Code
Greptile Summary
This PR aligns vertical spacing for TipTap and Milkdown task list items with bullet and ordered lists by setting
margin-top/margin-bottomto0.125em(up from0) and removing the hardcodedline-height: 1.25so it inherits from the parent. The compact-mode (.prose-tight) override retains higher CSS specificity and continues to zero out task list item margins correctly.Confidence Score: 5/5
Safe to merge — minimal, targeted CSS change with no logic or specificity issues.
All changes are P2 or lower; the margin/line-height alignment is correct, and the compact-mode (.prose-tight) cascade is preserved by higher selector specificity (0,3,0,1 vs 0,2,0,2).
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Task list item rendered] --> B{Is .prose-tight active?} B -- No --> C[Apply .ProseMirror ul/li task selector\nmargin: 0.125em, line-height: inherited] B -- Yes --> D[.prose-tight .ProseMirror.prose li\nspecificity 0,3,0,1 wins] D --> E[margin: 0 — compact mode] C --> F[Spacing matches bullet/ordered lists]Reviews (1): Last reviewed commit: "fix(editor): match task list item spacin..." | Re-trigger Greptile